Skip to content

Add more subscription metrics#2861

Merged
joshua-spacetime merged 3 commits into
masterfrom
joshua/subscription-lock-metrics
Jun 13, 2025
Merged

Add more subscription metrics#2861
joshua-spacetime merged 3 commits into
masterfrom
joshua/subscription-lock-metrics

Conversation

@joshua-spacetime

Copy link
Copy Markdown
Contributor

Description of Changes

Adds new metrics for subscriptions such as compilation time and the number of tasks waiting to acquire the subscription lock.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

Tested manually while running performance tests

@joshua-spacetime joshua-spacetime force-pushed the joshua/subscription-lock-metrics branch from f2d5736 to 554f59c Compare June 13, 2025 00:23
@joshua-spacetime joshua-spacetime self-assigned this Jun 13, 2025
@joshua-spacetime joshua-spacetime requested a review from mamcx June 13, 2025 16:02

@mamcx mamcx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Such as compilation time and the number of tasks waiting to acquire the subscription lock
@joshua-spacetime joshua-spacetime force-pushed the joshua/subscription-lock-metrics branch from d8b0f20 to cf208a3 Compare June 13, 2025 18:52
@joshua-spacetime joshua-spacetime added this pull request to the merge queue Jun 13, 2025
Merged via the queue into master with commit 193c0d4 Jun 13, 2025
24 of 31 checks passed
@joshua-spacetime joshua-spacetime deleted the joshua/subscription-lock-metrics branch June 13, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants